Improve documentation of the router #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 101e6dd): https://yew-rs--pr2166-router-docs-7bqlpr7d.web.app (expires Sun, 28 Nov 2021 17:55:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
voidpumpkin
requested changes
Nov 21, 2021
voidpumpkin
added
documentation
S-waiting-on-author
ranile
reviewed
Nov 21, 2021
There was a problem hiding this comment.
Can you also add a must_use attribute to HistoryListener struct?
voidpumpkin
previously approved these changes
Nov 21, 2021
There was a problem hiding this comment.
@Madoshakalaka @hamza1311 I suggest we merge this as is and do our own PR's to the docs according to our comments. It will be faster and less burden on this PR contributor
I will remove the automatic closing of the issue.
|
@voidpumpkin the comments here are GitHub suggestions. You can commit those and then merge the PR |
Co-authored-by: Matt <44753941+Madoshakalaka@users.noreply.github.com>
Co-authored-by: Matt <44753941+Madoshakalaka@users.noreply.github.com>
Co-authored-by: Muhammad Hamza <muhammadhamza1311@gmail.com>
Co-authored-by: Muhammad Hamza <muhammadhamza1311@gmail.com>
Co-authored-by: Muhammad Hamza <muhammadhamza1311@gmail.com>
voidpumpkin
reviewed
Nov 21, 2021
voidpumpkin
reviewed
Nov 21, 2021
voidpumpkin
previously approved these changes
Nov 21, 2021
ranile
reviewed
Nov 21, 2021
ranile
approved these changes
Nov 21, 2021
voidpumpkin
approved these changes
Nov 21, 2021
voidpumpkin
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1852
Checklist
cargo make pr-flow