Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to support keyed attributes #1076

Merged
merged 20 commits into from
Apr 13, 2020
Merged

Updated to support keyed attributes #1076

merged 20 commits into from
Apr 13, 2020

Commits on Mar 27, 2020

  1. Add keys to components

    @deep-gaurav
    deep-gaurav committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    ae23594 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2020

  1. Merge branch 'master' of github.com:yewstack/yew

    @mrh0057
    mrh0057 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    7bd7305 View commit details
    Browse the repository at this point in the history

  2. Switched to HashMap for added performance. Fixed issue if their isn't… 

    … a key on the nodes to not process the list.

Issue yewstack#479
    @mrh0057
    mrh0057 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    66be935 View commit details
    Browse the repository at this point in the history

  3. Ran cargo fmt.

    @mrh0057
    mrh0057 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    b9bd4af View commit details
    Browse the repository at this point in the history

  4. Deleted the node since we don't need it. 

    Switched to using remove instead of get_mut() to make it so we don't
need to do a full scan.

Issue yewstack#479
    @mrh0057
    mrh0057 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    ca2f74e View commit details
    Browse the repository at this point in the history

  5. Changed the key data type to Option<String>. 

    Issue yewstack#479.
    @mrh0057
    mrh0057 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    5ab1aab View commit details
    Browse the repository at this point in the history

  6. Removed rls config file.

    @mrh0057
    mrh0057 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    73fc779 View commit details
    Browse the repository at this point in the history

  7. Fixed macro test to add the additional VChild parameter.

    @mrh0057
    mrh0057 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    c8cafbb View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2020

  1. Updated the code to handle cases where the root has a key. 

    Nodes with keys are in a hashmap and nodes without are in vector.
Added an error if duplicate keys are in the hashmap and outputs the duplicate key.

Issue yewstack#479
    @mrh0057
    mrh0057 committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    c9b528c View commit details
    Browse the repository at this point in the history

  2. Updated vlist to have key() attribute. 

    Issue yewstack#479
    @mrh0057
    mrh0057 committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    394141d View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Updated vlist without a key.

    @mrh0057
    mrh0057 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    0eea074 View commit details
    Browse the repository at this point in the history

  2. Added a user defined key to vlist.

    @mrh0057
    mrh0057 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    7322678 View commit details
    Browse the repository at this point in the history

  3. Removed logging statement.

    @mrh0057
    mrh0057 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    e444b3a View commit details
    Browse the repository at this point in the history

  4. Made the changes requested. Still need to add macro tests.

    @mrh0057
    mrh0057 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    c09fbad View commit details
    Browse the repository at this point in the history

  5. Updated the macro tests when the syntax changes.

    @mrh0057
    mrh0057 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    78cc1ce View commit details
    Browse the repository at this point in the history

  6. Ran cargo fmt.

    @mrh0057
    mrh0057 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    116a09f View commit details
    Browse the repository at this point in the history

  7. Switched to returning a reference for the key. 

    Removed the key comparision for vtag.
    @mrh0057
    mrh0057 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    d703ace View commit details
    Browse the repository at this point in the history

  8. Fixed clippy warning.

    @mrh0057
    mrh0057 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    2ad0631 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Switch to use == to do the comparision to fix clippy error.

    @mrh0057
    mrh0057 committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    11b74a7 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Add clippy ignore

    @jstarry
    jstarry committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    818446a View commit details
    Browse the repository at this point in the history