Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wildcard requirement for bincode dependency #1349

Merged
merged 4 commits into from
Jun 29, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 26, 2020

Updates the requirements on bincode to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 26, 2020
@teymour-aldridge teymour-aldridge mentioned this pull request Jun 28, 2020
1 task
@joonazan
Copy link

fixes #1352

Updates the requirements on [bincode](https://github.com/servo/bincode) to permit the latest version.
- [Release notes](https://github.com/servo/bincode/releases)
- [Commits](https://github.com/servo/bincode/commits)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/bincode-approx-1.3.1 branch from 0beb90c to 00b5f22 Compare June 28, 2020 16:54
@jstarry jstarry changed the title Update bincode requirement from ~1.2.1 to ~1.3.1 Use wildcard requirement for bincode dependency Jun 29, 2020
@teymour-aldridge
Copy link
Contributor

Would it be better to use 1 instead of a wildcard?

@jstarry
Copy link
Member

jstarry commented Jun 29, 2020

@teymour-aldridge hmm I'm not sure. Why do you suggest that?

@jstarry jstarry removed the automerge label Jun 29, 2020
@teymour-aldridge
Copy link
Contributor

I think they follow SemVer, so if there was ever a v2 of bincode then that might cause breakages.

@jstarry
Copy link
Member

jstarry commented Jun 29, 2020

That's fair, I'll use 1 then, thanks!

@teymour-aldridge
Copy link
Contributor

No problem!

@jstarry jstarry merged commit dcdcfe7 into master Jun 29, 2020
@jstarry jstarry deleted the dependabot/cargo/bincode-approx-1.3.1 branch June 29, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants