Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] wasm-bindgen exact version #1482

Merged
merged 1 commit into from
Aug 15, 2020
Merged

[docs] wasm-bindgen exact version #1482

merged 1 commit into from
Aug 15, 2020

Conversation

vincentserpoul
Copy link
Contributor

Description

I just tried the sample app.
I had to specify the exact wasm-bindgen otherwise, wasm-pack is hanging

same as: rustwasm/wasm-pack-template#44

Fixes just docs

Checklist:

  • I have run ./ci/run_stable_checks.sh
  • I have reviewed my own code
  • I have added tests

I just tried the sample app.
I had to specify the exact wasm-bindgen otherwise, wasm-pack is hanging

same as: rustwasm/wasm-pack-template#44
@jstarry jstarry changed the title [oocs] wasm-bindgen exact version [docs] wasm-bindgen exact version Aug 15, 2020
@jstarry
Copy link
Member

jstarry commented Aug 15, 2020

Oh that's too bad, thanks for fixing!

@jstarry jstarry merged commit fae9fb9 into yewstack:master Aug 15, 2020
@siku2
Copy link
Member

siku2 commented Aug 15, 2020

I'm really curious why this happens though. What version of wasm-pack are you using, @vincentserpoul? (wasm-pack -V)

@vincentserpoul
Copy link
Contributor Author

my version is 0.9.1

@siku2
Copy link
Member

siku2 commented Aug 15, 2020

If you can still reproduce the issue, could you run wasm-pack with the --verbose flag and share the output?

@vincentserpoul
Copy link
Contributor Author

just tried to restart from scratch, I can't reproduce anymore :/

jstarry pushed a commit that referenced this pull request Aug 16, 2020
I just tried the sample app.
I had to specify the exact wasm-bindgen otherwise, wasm-pack is hanging

same as: rustwasm/wasm-pack-template#44
teymour-aldridge pushed a commit to teymour-aldridge/yew that referenced this pull request Sep 1, 2020
I just tried the sample app.
I had to specify the exact wasm-bindgen otherwise, wasm-pack is hanging

same as: rustwasm/wasm-pack-template#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants