Optimize VTag construction, memory footprint and patching

[bakape]

Description

#1905 overwrote the optimizations merged in #1867. This PR remerges those optimizations and additionally:

• Moves more VTag construction logic to compile-time via the html! macro
• Reduces VTag memory footprint via enums
• Reduces enum branching during VTag patching. This includes the various Option<T> values already present before this PR.

Benchmark results using https://github.com/bakape/js-framework-benchmark

The small degradation of row swapping performance can be addressed by merging #1555 to improve VList patching vectorization.

Checklist

• I have run cargo make pr-flow
• I have reviewed my own code
• I have added tests

[bakape]

Is support for Rust 1.45 still required? It's almost a year old release by this point.

[teymour-aldridge]

I thought we'd bumped the MSRV to 1.51.0 991abab

[bakape]

@teymour-aldridge Seems this was missed in that PR: https://github.com/yewstack/yew/blob/master/.github/workflows/pull-request.yml#L131.
I'll PR a fix.

[ranile]

Nah, we just bumped the version for tests in CI. MSRV is still the same

[bakape]

Hmm, should I amend my code with some unsafe then? The alternatives would be conditional compilation on rust version or some performance penalty by adding std::mem::take.

[teymour-aldridge]

I think we can bump the MSRV, but that's definitely a question for @cecton, @jstarry or @siku2.

…

On 09/07/2021 17:40, bakape wrote: Hmm, should I amend my code with some |unsafe| then? The alternatives would be conditional compilation on rust version or some performance penalty by adding |std::mem::take|. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1947 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFSTPK7INAOSGS6WZBMRETTW4Q6LANCNFSM5ABPKQYQ>.

[teymour-aldridge]

Yes, there have definitely been quite a few Git issues recently.

…

On 09/07/2021 17:30, bakape wrote: @teymour-aldridge <https://github.com/teymour-aldridge> Seems this was missed in that PR: https://github.com/yewstack/yew/blob/master/.github/workflows/pull-request.yml#L131 <https://github.com/yewstack/yew/blob/master/.github/workflows/pull-request.yml#L131>. I'll PR a fix. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1947 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKFSTPJDW5SWAHRUR4YB65TTW4P3ZANCNFSM5ABPKQYQ>.

[cecton]

I'm totally fine bumping the MSRV version but I think it's best to have an older maintainer than me on this subject.

[jstarry]

Bump MSRV as needed, it's just added as an FYI to any consumers of the library 😄

[github-actions]

Visit the preview URL for this PR (updated for commit c4f62ff):

https://yew-rs--pr1947-fix-remerge-vtag-con-bwhafw1o.web.app

_{(expires Sun, 25 Jul 2021 16:20:48 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

[cecton]

Looks good to me 👍 One more reviewer would be nice

Pull request has been modified.

[bakape]

@siku2 Everything addressed.