Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use into_prop_value to convert str prop to Option<String> #2080

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Use into_prop_value to convert str prop to Option<String> #2080

merged 1 commit into from
Sep 24, 2021

Conversation

Xavientois
Copy link
Contributor

Description

Make code simpler and more robust by relying on the into_prop_value trait function for conversion instead of the Into trait.

Fixes #2034

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@mc1098 mc1098 added the A-yew-macro Area: The yew-macro crate label Sep 24, 2021
mc1098
mc1098 approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@mc1098 mc1098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix :)

@siku2 siku2 merged commit 97498cd into yewstack:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mc1098 mc1098 mc1098 approved these changes

Assignees
No one assigned
Labels
A-yew-macro Area: The yew-macro crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting optional props with base expr fails without Some(...)
3 participants
@Xavientois @mc1098 @siku2