Respect <base> href in Links href #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidpumpkin
requested changes
Nov 22, 2021
voidpumpkin
approved these changes
Nov 22, 2021
ranile
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR
Link<impl Routable>sets thehrefattribute taking into account a given base path, in the same manner as theBrowserHistorycomponent does. This should fix some screen reader setups.Take for example the router example. Hovering over the "Posts" link in the app bar should say
https://examples.yew.rs/router/postsbut before this patch displayshttps://examples.yew.rs/posts- navigation works fine in both cases though.Checklist
cargo make pr-flow