Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: boids and password_strength deployment #2695

Merged
merged 2 commits into from
May 21, 2022

Conversation

WorldSEnder
Copy link
Member

@WorldSEnder WorldSEnder commented May 20, 2022

Description

Two examples currently fail to deploy correctly, since they are left with undefined symbols, due to rust-lang/rust#96486.
This contains a workaround for the problem, which slightly increases the wasm size, but at least makes them run.

Fixes a comment on discord
Fixes #2696

Checklist

  • I have reviewed my own code
  • I have added tests

also adds a compile failure when examples have unresolved symbols
github-actions[bot]
github-actions bot previously approved these changes May 20, 2022
@github-actions
Copy link

github-actions bot commented May 20, 2022

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
boids 172.824 172.824 0 0.000%
contexts 109.636 109.636 0 0.000%
counter 86.653 86.653 0 0.000%
counter_functional 87.303 87.303 0 0.000%
dyn_create_destroy_apps 89.797 89.797 0 0.000%
file_upload 102.621 102.621 0 0.000%
function_memory_game 167.382 167.382 0 0.000%
function_router 350.583 350.583 0 0.000%
function_todomvc 161.995 161.995 0 0.000%
futures 226.659 226.659 0 0.000%
game_of_life 107.539 107.539 0 0.000%
inner_html 83.686 83.686 0 0.000%
js_callback 112.874 112.874 0 0.000%
keyed_list 195.038 195.038 0 0.000%
mount_point 86.282 86.282 0 0.000%
nested_list 115.917 115.917 0 0.000%
node_refs 90.452 90.452 0 0.000%
password_strength 1539.624 1539.624 0 0.000%
portals 97.192 97.192 0 0.000%
router 319.641 319.641 0 0.000%
simple_ssr 494.016 494.016 0 0.000%
ssr_router 425.572 425.572 0 0.000%
suspense 110.582 110.582 0 0.000%
timer 89.391 89.391 0 0.000%
todomvc 143.054 143.054 0 0.000%
two_apps 87.285 87.285 0 0.000%
web_worker_fib 153.528 153.528 0 0.000%
webgl 87.372 87.372 0 0.000%

✅ None of the examples has changed their size significantly.

ranile
ranile previously approved these changes May 20, 2022
Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it fixes it in CI, it would be nice if we could document somewhere that the nightly compiler has this bug so those unaware of it can learn about it.

I'm fine with a temporary note on the website or a GitHub issue stating the problem (though I would prefer the former as we also have recommendations to use nightly there)

@WorldSEnder WorldSEnder dismissed stale reviews from ranile and github-actions[bot] via 0827a2f May 20, 2022 21:45
@WorldSEnder WorldSEnder requested a review from ranile May 20, 2022 21:46
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 0827a2f):

https://yew-rs--pr2695-fix-additional-examp-kzgy92c4.web.app

(expires Fri, 27 May 2022 21:53:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ranile ranile merged commit a6df894 into yewstack:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken examples when compiling with nightly rust and following size optimizations
2 participants