Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Transferable trait #319

Merged
merged 5 commits into from
Sep 30, 2019
Merged

Conversation

hgzimmerman
Copy link
Member

Anything that implements Serialize + Deserialize<'de> will be a valid message that can be sent to and from agents.

@hgzimmerman
Copy link
Member Author

See #320

@jstarry
Copy link
Member

jstarry commented Sep 23, 2019

@hgzimmerman I think we should kill Transferable 😄 Can you update this PR when you have the time?

@hgzimmerman
Copy link
Member Author

Just noticed this, will get to it soonish.

@hgzimmerman
Copy link
Member Author

You might want to slap a breaking change label on this before its merged.

@jstarry jstarry self-requested a review September 30, 2019 01:00
Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance 😜

@jstarry
Copy link
Member

jstarry commented Sep 30, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 30, 2019
319: Remove Transferable trait r=jstarry a=hgzimmerman

Anything that implements Serialize + Deserialize<'de> will be a valid message that can be sent to and from agents.

Co-authored-by: Henry Zimmerman <zimhen7@gmail.com>
Co-authored-by: Justin Starry <jstarry@users.noreply.github.com>
@jstarry jstarry merged commit 74583ed into yewstack:master Sep 30, 2019
llebout pushed a commit to llebout/yew that referenced this pull request Jan 20, 2020
* remove transferable trait

* remove transferable from router example, run cargo fmt

* cargo fmt

* Remove Transferable from multi_thread example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants