Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.21 release #3412

Merged
merged 10 commits into from
Sep 29, 2023
Merged

Prepare for 0.21 release #3412

merged 10 commits into from
Sep 29, 2023

Conversation

ranile
Copy link
Member

@ranile ranile commented Sep 23, 2023

TODOs

  • Version website
  • Ask ChatGPT to write a blog post

@ranile ranile marked this pull request as ready for review September 23, 2023 17:33
@ranile ranile added A-yew-router Area: The yew-router crate A-yew Area: The main yew crate A-yew-agent Area: The yew-agent crate labels Sep 23, 2023
github-actions[bot]
github-actions bot previously approved these changes Sep 23, 2023
@ranile ranile requested review from cecton and futursolo September 23, 2023 17:34
github-actions[bot]
github-actions bot previously approved these changes Sep 23, 2023
github-actions[bot]
github-actions bot previously approved these changes Sep 23, 2023
@github-actions
Copy link

github-actions bot commented Sep 23, 2023

Visit the preview URL for this PR (updated for commit f667043):

https://yew-rs--pr3412-release-21-gv184iqg.web.app

(expires Thu, 05 Oct 2023 15:37:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ranile
Copy link
Member Author

ranile commented Sep 23, 2023

Whoever merges this PR should publish the following packages:
yew yew-macro yew-router yew-router-macro yew-agent yew-agent-macro

using the publish action

@its-the-shrimp
Copy link
Contributor

Links to the authors of the changes in the changelog seem to be malformed, is the changelog autogenerated?

@ranile
Copy link
Member Author

ranile commented Sep 27, 2023

Links to the authors of the changes in the changelog seem to be malformed, is the changelog autogenerated?

Yes, it is automated. I would prefer to fix the tool and changelog after release though...

Copy link
Member

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little bit skeptical about the content that ChatGPT generates.

website/blog/2023-09-23-release-0-21.md Outdated Show resolved Hide resolved
website/blog/2023-09-23-release-0-21.md Outdated Show resolved Hide resolved
Comment on lines -122 to +123
googleAnalytics: {
trackingID: 'UA-141789564-1',
gtag: {
trackingID: 'G-DENCL8P4YP',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very familiar with the tracking we use, but is this change intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, previous one was broken. I realized that while creating a new version

website/blog/2023-09-23-release-0-21.md Outdated Show resolved Hide resolved
@ranile
Copy link
Member Author

ranile commented Sep 27, 2023

I am a little bit skeptical about the content that ChatGPT generates.

Fair. I reviewed it manually though, so everything that is in there is what got past me

github-actions[bot]
github-actions bot previously approved these changes Sep 27, 2023
Co-authored-by: Kaede Hoshikawa <futursolo@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Sep 27, 2023
@cecton
Copy link
Member

cecton commented Sep 27, 2023

I have this very small PR to include if possible 🙏 #3419 (it's okay I understand if not! no worry)

@ranile
Copy link
Member Author

ranile commented Sep 28, 2023

I have this very small PR to include if possible 🙏 #3419 (it's okay I understand if not! no worry)

@cecton what if we published 0.21.1 with this change? I really want to get 0.21.0 out and if we merged it now, it would require redoing the changelog and stuff

@ranile ranile requested a review from futursolo September 28, 2023 15:24
@cecton
Copy link
Member

cecton commented Sep 29, 2023

@hamza1311 of course!! no worry I perfectly understand. Thank you for you work on this release btw!

@futursolo futursolo merged commit 5e823e7 into yewstack:master Sep 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate A-yew-agent Area: The yew-agent crate A-yew-router Area: The yew-router crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants