-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 0.21 release #3412
Prepare for 0.21 release #3412
Conversation
Visit the preview URL for this PR (updated for commit f667043): https://yew-rs--pr3412-release-21-gv184iqg.web.app (expires Thu, 05 Oct 2023 15:37:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Whoever merges this PR should publish the following packages: using the publish action |
Links to the authors of the changes in the changelog seem to be malformed, is the changelog autogenerated? |
Yes, it is automated. I would prefer to fix the tool and changelog after release though... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little bit skeptical about the content that ChatGPT generates.
googleAnalytics: { | ||
trackingID: 'UA-141789564-1', | ||
gtag: { | ||
trackingID: 'G-DENCL8P4YP', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very familiar with the tracking we use, but is this change intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, previous one was broken. I realized that while creating a new version
Fair. I reviewed it manually though, so everything that is in there is what got past me |
Co-authored-by: Kaede Hoshikawa <futursolo@users.noreply.github.com>
I have this very small PR to include if possible 🙏 #3419 (it's okay I understand if not! no worry) |
@hamza1311 of course!! no worry I perfectly understand. Thank you for you work on this release btw! |
TODOs