-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit duplicate key check #3785
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also a bit more defensive in production code, this should not lead to any slowdown or changes in code with proper keys
don't set the panic hook if we are already panicking
Size Comparison
✅ None of the examples has changed their size significantly. |
Benchmark - coreYew Master
Pull Request
|
Visit the preview URL for this PR (updated for commit 124b51b): https://yew-rs--pr3785-duplicate-key-check-w02i5ixk.web.app (expires Sat, 04 Jan 2025 16:19:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
geoffjay
pushed a commit
to geoffjay/yew
that referenced
this pull request
Jan 25, 2025
* explicit duplicate key check in debug_assertions also a bit more defensive in production code, this should not lead to any slowdown or changes in code with proper keys CI changes: * force install cli tools over cached versions on version mismatch * Upload PR information for CI see also: actions/upload-artifact#618 misc: * fix panic in panic don't set the panic hook if we are already panicking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A discussion on discord shows a hard to read error message when accidentally using duplicate keys in lists.
While this is still not supported with this PR, change this to a nicer error message, identifying the offending index and key in the list.
Example stack trace: