Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dashed tag labels #512

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Support dashed tag labels #512

merged 1 commit into from
Jul 3, 2019

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Jul 3, 2019

This now compiles correctly

html! {
  <div data-key="abc"></div>
}

@jstarry jstarry requested a review from therustmonk July 3, 2019 13:09
@jstarry
Copy link
Member Author

jstarry commented Jul 3, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 3, 2019
@bors @jstarry
Merge #512
446983a 
512: Support dashed tag labels r=jstarry a=jstarry

This now compiles correctly
```
html! {
  <div data-key="abc"></div>
}
```

Co-authored-by: Justin Starry <jstarry@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jul 3, 2019

Build succeeded

@bors bors bot merged commit 8962b77 into yewstack:master Jul 3, 2019
@jstarry jstarry deleted the html-macro-dashed-labels branch July 7, 2019 23:21
@jstarry jstarry mentioned this pull request Jul 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therustmonk therustmonk therustmonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstarry @therustmonk