Add keyboard service #647
Merged
Add keyboard service #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that services should be feature gated, thanks for creating the issue #648 for it! |
jstarry
requested changes
Sep 22, 2019
There was a problem hiding this comment.
Looks good but I think we should add some comments about compatibility. Looks like these events are not supported on some browsers like Safari for example. Please add a note about that and a link to https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers, thanks!
|
Would it be wise to expand the scope of this PR to include all GlobalEventHandlers as a service instead of just keyboard-specific events? |
jstarry
approved these changes
Sep 27, 2019
llebout
pushed a commit
to llebout/yew
that referenced
this pull request
Jan 20, 2020
* Add keyboard service * fix not working implementation; run cargo fmt * make callback to keyboard event use KeyPressEvent instead of String * add key_down and key_up events as well * link to documentation and provide compatibility notice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a keyboard service so key events can be registered on elements like
document.Thanks to cradee (@cradee_gitlab on the yew gitter) for making it apparent something like this might be useful and for implementing a prototype.
Edit: a thought related to this feature.
This service is pretty simple, and could be done in someone's own project without too much difficulty. Should there be a bar that must be cleared for service additions? Would it make sense to create another project within yewstack for accessory services - ones that aren't core to most applications, but are common enough to justify sticking them in a library for reuse? Should all services be moved to another crate and be reexported from yew but gated by a default "on" feature flag?