Add GDA Object Model #1911
Merged
Add GDA Object Model #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the existing DirectAnswer model, we will take in an object from search-core (GenerativeDirectAnswerResponse in this case) and use it to construct a model. J=WAT-4592 TEST=auto Ran unit tests
Fondryext
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Normally on the develop branch we'll make a version like '2.5.0-beta.5' to make it clear that the version isn't the real one.
In this case, though, I think it actually makes more sense to have a branch, not develop, where we push most of the changes to until all the sdk work for this portion is done - since this change by itself isn't really a full change. Up to you on that branch naming.
Fondryext
reviewed
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the existing
DirectAnswermodel, we will take in an object fromsearch-core(GenerativeDirectAnswerResponsein this case) and use it to construct a model.J=WAT-4592
TEST=auto
Ran unit tests