Skip to content

Commit

Permalink
Migrate from tsc to rollup for the build process (#38)
Browse files Browse the repository at this point in the history
this PR migrates the build chain from tsc to rollup, as part of the changes discovered in the investigation from this [PR](yext/chat-ui-react#38): 

J=CLIP-556
TEST=manual

see that all unit tests and the two test site still works as expected
published an alpha version `[0.7.0-alpha.38.2](https://www.npmjs.com/package/@yext/chat-headless/v/0.7.0-alpha.38.2)` of headless and alpha version `[0.6.0-alpha.38.3](https://www.npmjs.com/package/@yext/chat-headless-react/v/0.6.0-alpha.38.3)` of headless-react, and see that it still works as expected in vite/pagesjs and sonic/alpha.

Will publish v0.7.0 of headless once merged. Then update headless-react dep in a separate PR to publish 0.6.0
  • Loading branch information
yen-tt authored Sep 11, 2023
1 parent 1fc5e8a commit 824e0a2
Show file tree
Hide file tree
Showing 23 changed files with 272 additions and 262 deletions.
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ module.exports = {
"**/index.ts",
"**/build",
"**/coverage",
"rollup.config.mjs",
"*.d.ts",
],
parserOptions: {
Expand Down
19 changes: 0 additions & 19 deletions apps/test-site/craco.config.js

This file was deleted.

9 changes: 3 additions & 6 deletions apps/test-site/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
"web-vitals": "^2.1.4"
},
"scripts": {
"start": "craco start",
"build": "craco build",
"test": "craco test"
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test"
},
"browserslist": {
"production": [
Expand All @@ -29,8 +29,5 @@
"last 1 firefox version",
"last 1 safari version"
]
},
"devDependencies": {
"@craco/craco": "^7.1.0"
}
}
Loading

0 comments on commit 824e0a2

Please sign in to comment.