chat-headless: reset EventClient if active when restarting convo #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a ChatEventClient is the active client when restarting the conversation, call its resetSession method and move to the next available client for continuation of the conversation. TEST=manual Ran with locally updated chat-core, saw expected results in test app. Added and updated unit tests to reflect new behavior.
yen-tt
reviewed
Jul 9, 2024
yen-tt
reviewed
Jul 10, 2024
yen-tt
approved these changes
Jul 10, 2024
yen-tt
reviewed
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a ChatEventClient is the active client when restarting the conversation, call its resetSession method and reset to the bot client.
TEST=manual
Ran with locally updated chat-core, saw expected results in test app. Added and updated unit tests to reflect new behavior.