Upgrade rollup + babel subpackages to resolve vulnerabilities #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes upgrade of @yext/eslint-config which fixes transitive vulnerabilities, and also upgrades separately imported dependencies within chat-headless, both in babel subpackages and the version of rollup used in the test site. J=VULN-39423,VULN-39394 TEST=manual Ran tests and linter, saw no issues.
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
Comment on lines
6088
to
+6089
| "node_modules/caniuse-lite": { | ||
| "version": "1.0.30001487", | ||
| "version": "1.0.30001680", |
There was a problem hiding this comment.
Legal Risk:
caniuse-lite 1.0.30001680 was released under the CC-BY-4.0 license, a license currently prohibited by your organization. Merging is blocked until this is resolved
Recommendation:
Reach out to your security team or Semgrep admin to address this issue. In special cases, exceptions may be made for dependencies with violating licenses, however, the general recommendation is to avoid using a dependency under such a license
nbramblett
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes upgrade of @yext/eslint-config which fixes transitive vulnerabilities, and also upgrades separately imported dependencies within chat-headless, both in babel subpackages and the version of rollup used in the test site.
Relevant patches in @yext/eslint-config:
yext/eslint-config#10
yext/eslint-config#11
J=VULN-39423,VULN-39394
TEST=manual
Ran tests and linter, saw no issues.