cleanup

yext · Nov 3, 2023 · 42f24d6 · 42f24d6
1 parent 8e5782d
commit 42f24d6
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/pages/src/dev/server/ssr/getLocalData.ts b/packages/pages/src/dev/server/ssr/getLocalData.ts
@@ -146,15 +146,15 @@ export const getLocalDataForEntityOrStaticPage = async ({
 }: {
   locale: string;
   featureName: string;
-  entityId?: string;
+  entityId: string;
 }) => {
   const localData = await getLocalData((data) => {
-    const isEntityPage = !!entityId;
+    const isStatic = entityId === "";
+    const isMatchingEntity = !isStatic && entityId === data.id;
     const matchesNameAndLocale =
       data.locale === locale && data.__.name === featureName;
-    return isEntityPage
-      ? matchesNameAndLocale && data.id === entityId
-      : matchesNameAndLocale;
+
+    return (isStatic || isMatchingEntity) && matchesNameAndLocale;
   });
   if (!localData) {
     throw new Error(