fix: removes warning about --experimental flags #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the templatesJson to the header so that we can access it in the Visual Editor. Tested locally and verified that the templatesJson was present in a script tag in the header. Also verified that `npm run prod` still works as expected and the templatesJson is not present.
dependent on #532 view changes made in last commit for actual PR. The rest of commits are from PR#532
This provides a post request option for `serverRenderRoute` which overrides the c_visualLayouts field of the pulled document with the overrides that are passed in from the request. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Kilpatrick <mkilpatrick@yext.com>
|
@mkilpatrick lmk if there's more specific testing I should be doing |
mkilpatrick
reviewed
Aug 19, 2024
| // React should really export this file as it's the correct solution to use with Node without | ||
| // experimental flags. Once that happens the .js can be added back to the react-dom/server usages. | ||
| // https://github.com/facebook/react/issues/26170 | ||
| export function resolve(specifier, context, nextResolve) { |
There was a problem hiding this comment.
Did you test using different versions of React and Node, along with testing those same combos in Windows? I don't want to remove this without verifying we're not breaking something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally with node 18 and 20
Tested in platform with a starter site as well.
PR that added this code initially