Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade): pin Vite to version 5 #561

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix(upgrade): pin Vite to version 5 #561

merged 1 commit into from
Jan 3, 2025

Conversation

mkilpatrick
Copy link
Collaborator

No description provided.

@mkilpatrick mkilpatrick requested a review from a team as a code owner January 2, 2025 21:00
Copy link
Contributor

@jwartofsky-yext jwartofsky-yext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Should we add latestMajorVersion for other packages like yext/search-ui-react?

@mkilpatrick
Copy link
Collaborator Author

lgtm

Should we add latestMajorVersion for other packages like yext/search-ui-react?

I think those are fine to leave but we can reassess if it ever becomes an issue.

@mkilpatrick mkilpatrick merged commit 7dc2dd3 into main Jan 3, 2025
16 checks passed
@mkilpatrick mkilpatrick deleted the vite-version branch January 3, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants