Update buildchain to use rollup in order to improve esm support #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library exported an esm version, however it didn't work with all esm tools becase some require "type": "module" to be set, or the files to end in ".mjs". By moving over to rollup, we can output the esm files with the ".mjs" extension which makes this library work with vite. This change is based on the approach which Chat decided on: yext/chat-ui-react#38 J=BACK-2527 TEST=manual Manually ran the test site locally and confirmed the requests still fire correctly. I still need to test this with vite.
Pull Request Test Coverage Report for Build 6176585419
💛 - Coveralls |
|
Upon further testing, the existing library works just fine with the pages js dev and prod builds, so I don't think this change is needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library exported an esm version, however it didn't work with all esm tools becase some require "type": "module" to be set, or the files to end in ".mjs". By moving over to rollup, we can output the esm files with the ".mjs" extension which makes this library work with vite.
This change is based on the approach which Chat decided on: yext/chat-ui-react#38
J=BACK-2527
TEST=manual
Manually ran the test site locally and confirmed the requests still fire correctly. I still need to test this with vite.