Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lodash/isEqual is not listed as a dependency #294

Closed
chrisvariety opened this issue Aug 16, 2022 · 1 comment · Fixed by #318
Closed

lodash/isEqual is not listed as a dependency #294

chrisvariety opened this issue Aug 16, 2022 · 1 comment · Fixed by #318

Comments

@chrisvariety
Copy link

search-ui-react/src/utils/filterutils.tsx

Line 2 in 21087c8

import isEqual from 'lodash/isEqual';

lodash/isEqual is missing from the dependencies list in package.json. It is listed in devDependencies, but it is not a dev-only dependency.
@chrisvariety
Copy link
Author

chrisvariety commented Aug 16, 2022 •
edited
Loading

Updating to match this syntax would be good as well:

search-ui-react/src/hooks/useRemovableFilters.ts

Line 2 in 96cf7f9

import { isEqual } from 'lodash';

tmeyer2115 added a commit that referenced this issue Oct 18, 2022
@tmeyer2115
Create hotfix v1.0.1.
ea571cf 
This hotfix fixes issue #294. We had `lodash` as a devDependency, even
though it's used in src.
@tmeyer2115 tmeyer2115 mentioned this issue Oct 18, 2022
Merged
tatimblin pushed a commit that referenced this issue Nov 3, 2022
@tmeyer2115 @tatimblin
Create hot-fix v1.0.1. (#318)
1e8ea96 
This hot-fix resolves #294. We had `lodash` as a devDependency, even though it's used in `src`. I also updated the import of `isEqual` in `filterutils.tsx` to follow best practices.

J=SLAP-2404
TEST=none
This was referenced Nov 3, 2022
Closed
Merged
tatimblin added a commit that referenced this issue Nov 3, 2022
@tatimblin @tmeyer2115
Create hotfix v1.0.1. (#325)
c24ae51 
This hotfix fixes issue #294. We had `lodash` as a devDependency, even
though it's used in src.

Co-authored-by: Tom Meyer <tmeyer@yext.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create hot-fix v1.0.1. yext/search-ui-react
1 participant
@chrisvariety