Upgrade Jest to v28 #169
Merged
Upgrade Jest to v28 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2455245851
💛 - Coveralls |
oshi97
reviewed
Jun 6, 2022
| @@ -0,0 +1,31 @@ | |||
| // This code is from | |||
There was a problem hiding this comment.
is it possible to use moduleNameMapper instead like suggested here? uuidjs/uuid#616 (comment)
It might be a little easier to find and remove later on
There was a problem hiding this comment.
It's ridiculous they haven't closed out uuidjs/uuid#616 for 4 months
There was a problem hiding this comment.
it is possible to use moduleNameMapper, but it seemed like that might have some consequences, discussed here: uuidjs/uuid#616 (comment)
oshi97
approved these changes
Jun 7, 2022
yen-tt
pushed a commit
that referenced
this pull request
Sep 28, 2022
This PR upgrades Jest from v27 to v28. Most of the breaking changes don't affect us, except for two: - To use the JSDOM test environment, `jest-environment-jsdom` now has to be installed separately - Jest now has full support for package exports, which can cause problems where file imports are not resolved correctly. Specifically, this is a problem for `uuid`. There is a discussion and proposed solution in this [GitHub issue](microsoft/accessibility-insights-web#5421 (comment)), which I used in this PR. To summarize, the fix is to add a custom resolver that forces Jest to use the CommonJS+node version of `uuid`, but leaves all other resolutions the same J=SLAP-2123 TEST=auto See that Jest tests pass.
Merged
nmanu1
added a commit
that referenced
this pull request
Sep 30, 2022
Upgrade Jest from v27 to v29. We had [previously](#169) upgraded Jest to v28, but had to [downgrade](#275) to v27 because at the time, `@storybook/test-runner` only supported up to v27. In v0.7 of `@storybook/test-runner`, they changed Jest to be an internal dependency instead of a peer dependency, allowing us to use whatever version of Jest we want. There was only one breaking change in v29 that affected our code, besides those that already needed to be made when upgrading from v27 to v28 (see previous PR [description](#169 (comment))). This was the `jsdom` upgrade from v19 to v20 in `jest-environment-jsdom`, which requires the `typescript` version to be 4.5 or higher. With the new support added in v29 and `uuid` v9, we are now able to remove the manual resolving needed in `tests/__setup__/resolver.ts`. For more context on why this was initially needed with Jest v28, see #169. J=SLAP-2376 TEST=manual See that existing tests still run properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Jest from v27 to v28. Most of the breaking changes don't affect us, except for two:
jest-environment-jsdomnow has to be installed separatelyuuid. There is a discussion and proposed solution in this GitHub issue, which I used in this PR. To summarize, the fix is to add a custom resolver that forces Jest to use the CommonJS+node version ofuuid, but leaves all other resolutions the sameJ=SLAP-2123
TEST=auto
See that Jest tests pass.