Fix visual coverage test in Github Actions #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current unit coverage is 88.84839650145773% |
yen-tt
added a commit
to yext/slapshot-reusable-workflows
that referenced
this pull request
Nov 18, 2022
the issue with coverage test in search-ui-react repo stems from errors caused within the visual tests from storybook due to missing mapbox API key. This is also an issue when running test workflow where mapbox related visual tests failed due to missing mapbox API key (it also failed silently / test github action "passed" when there are tests failed -- that will be address in this [item](https://yexttest.atlassian.net/browse/SLAP-2459)). J=SLAP-2467 TEST=auto - see that coverage GH now works as expected in this search-ui-react PR: yext/search-ui-react#339 - see that mapbox errors in test GH in search-ui-react no longer appear in this PR: yext/search-ui-react#339
tmeyer2115
approved these changes
Nov 18, 2022
yen-tt
added a commit
that referenced
this pull request
Nov 18, 2022
In addition to the changes in the [workflow PR](yext/slapshot-reusable-workflows#24), this up updates run-tests github action and coverage github action to pass mapbox api key so visual coverage test works as expected. J=SLAP-2467 TEST=auto see that run-tests github action and coverage github action passed -- looked into the logs, no false positive / errors related to visual coverage.
nmanu1
pushed a commit
that referenced
this pull request
Dec 2, 2022
In addition to the changes in the [workflow PR](yext/slapshot-reusable-workflows#24), this up updates run-tests github action and coverage github action to pass mapbox api key so visual coverage test works as expected. J=SLAP-2467 TEST=auto see that run-tests github action and coverage github action passed -- looked into the logs, no false positive / errors related to visual coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the changes in the workflow PR, this up updates run-tests github action and coverage github action to pass mapbox api key so visual coverage test works as expected.
J=SLAP-2467
TEST=auto
see that run-tests github action and coverage github action passed -- looked into the logs, no false positive / errors related to visual coverage.