Version 1.6.0 #439
Merged
Version 1.6.0 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main (v1.5.0) into develop
EmilyZhang777 Member EmilyZhang777 commented 4 days ago • This change adds a param so that callers can pass in a custom afterDropdownInputFocus method for FilterSearch's input box. This request was brought up to allow analytics event logging upon clicking on the input box. This change also bump the version to 1.6.0-beta.432.
### Changes 1. In accordance with [3] of [this PR](yext/slapshot-reusable-workflows#37), we updated `coverage.yml` to use `actions/download-artifact@v4`. 2. `main.yml`, and `update-snapshots.yml` actions of this repo were also updated to stop the node 16 deprecation warnings 3. Bumped versions for [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment/releases) to v4, [peter-evans/find-comment](https://github.com/peter-evans/find-comment/releases) to v3, and [actions/github-script](https://github.com/actions/github-script/releases?page=3) to v7.
*An automated PR which updates the version number in package.json and package-lock.json files* Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nmanu1
reviewed
May 15, 2024
There was a problem hiding this comment.
Great work! but the prop isn't only for analytics events, so I think we can word it a bit more generically, something like:
Added a custom afterDropdownInputFocus prop to the FilterSearch component that is called after focus enters the input. This can be used, for example, to fire analytics events when a user clicks into the FilterSearch input.
|
Adjusted wording, thanks |
|
Current unit coverage is 92.20456802383316% |
nmanu1
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
afterDropdownInputFocusprop to theFilterSearchcomponent that is called after focus enters the input. This can be used, for example, to fire analytics events when a user clicks into theFilterSearchinput. (Allow custom afterDropdownInputFocus on FilterSearch #432)