Dev/upgrade react markdown version #445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J=CLIP-1321 TEST=auto `npm run test` to ensure all tests pass with new mocked version of markdown
J=CLIP-1321 TEST=auto `npm run test` to ensure all tests pass with new mocked version of markdown
Contributor
|
Current unit coverage is 92.17687074829932% |
Contributor
|
I'd recommend manual testing a markdown field gets rendered properly after this change. You can follow the instruction here: https://docs.google.com/document/d/1EusosNnvHpT_J3RvTnz1IjnQBGQ_unnI7tfBJFoRzQA/edit |
J=CLIP-1321 TEST=auto `npm run test` to ensure all tests pass with new mocked version of markdown
Author
|
Example usage of markdown added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-markdownversion to 8.0.7<ReactMarkdown>to circumventcannot load ES moduleissues when doing jest testsJ=CLIP-1321
TEST=manual|auto
Ran
npm run testandnpm run buildto ensure no errors