Support removing array items #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshi97
reviewed
Jun 22, 2023
| const generateRemoveItem = useCallback( | ||
| (index: number) => () => { | ||
| const updatedItems = [...value]; | ||
| updatedItems.splice(index, 1); |
There was a problem hiding this comment.
I think we can try toSpliced here!
There was a problem hiding this comment.
Looks like support for it is being added in TS, but they haven't released a version that includes it yet
oshi97
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for removing existing array literal items. Update the nested props acceptance test to take a screenshot of what array props look like with expression and literal values.
Made an item for consolidating our other "Remove" buttons to use the generic
RemovableElementcomponent instead of having a button for each concept in Studio (e.g. removing pages, components, props, etc.).J=SLAP-2770
TEST=auto, manual
See that clicking the Remove Item button deletes the item and once there are no items, the top-level expression input is enabled again.