Use studio-plugin version in package.json instead of wildcard #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextaing
force-pushed
the
dev/link-studio-and-plugin
branch
from
d1f39ed
to
cb9e216
Compare
|
very pog, please make a corresponding item! |
oshi97
reviewed
Aug 29, 2023
alextaing
force-pushed
the
dev/link-studio-and-plugin
branch
from
cb9e216
to
f371357
Compare
oshi97
reviewed
Aug 29, 2023
nmanu1
reviewed
Aug 29, 2023
tmeyer2115
added a commit
that referenced
this pull request
Aug 31, 2023
## Changes - Studio's startup time is now considerably faster. This is due to an improvement in the logic for parsing Component and Template files. (#357) - The Studio Plugin is now a direct, explicit dependency of Studio. That means users only have to install `@yext/studio`. They don't need to worry about manually installing `@yext/studio-plugin` as well. (#355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In npm workspaces, you can use
*to point to a local dependency (i.e. another package), which is how we addstudio-pluginas a dependency ofstudio. This dependency is preserved as a symlink in the rootpackage-lock.json. Since the dependency version ofstudio-pluginin thestudiopackage.jsonwas*, there was not a concrete version ofstudio-pluginspecified, so users had to explicitly installstudioandstudio-plugin. This PR finds that we can still specify a version ofstudio-pluginin thestudiopackage.jsonand still preserve the symlink for local development.J-SLAP-2895
TEST=manual