Introduce Layouts to Studio
#367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextaing
force-pushed
the
dev/populate-layout-state
branch
from
0695b97
to
b02cdcc
Compare
oshi97
reviewed
Sep 7, 2023
oshi97
previously approved these changes
Sep 7, 2023
nmanu1
reviewed
Sep 7, 2023
nmanu1
reviewed
Sep 7, 2023
nmanu1
reviewed
Sep 8, 2023
nmanu1
approved these changes
Sep 8, 2023
Merged
tmeyer2115
added a commit
that referenced
this pull request
Sep 22, 2023
## Features - We've introduced the concept of Page Layouts (or Layouts) to Studio. A Page Layout is a pre-prescribed set of Components that you can apply to a Page. By default, Layouts live in the `src/layouts` directory. In the UI, a Layout can be applied via the "Insert" button. (#370, #367, #375) - There is now improved UX for creating or editing an Entity Page's Stream Scope. Instead of being raw inputs, the fields for Entity Ids, Entity Types, and Saved Filters are now drop-downs with the relevant options populated from the account. (#380) ## Changes - Repeaters and Modules have been officially deprecated and removed from Studio. (#369)
alextaing
pushed a commit
that referenced
this pull request
Sep 22, 2023
## Features - We've introduced the concept of Page Layouts (or Layouts) to Studio. A Page Layout is a pre-prescribed set of Components that you can apply to a Page. By default, Layouts live in the `src/layouts` directory. In the UI, a Layout can be applied via the "Insert" button. (#370, #367, #375) - There is now improved UX for creating or editing an Entity Page's Stream Scope. Instead of being raw inputs, the fields for Entity Ids, Entity Types, and Saved Filters are now drop-downs with the relevant options populated from the account. (#380) ## Changes - Repeaters and Modules have been officially deprecated and removed from Studio. (#369)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Layouts to Studio. Studio now recognizes layouts that appear in
src/layouts(or a custom dir) and stores their filepaths in a newlayoutsslice. Layout names are derived from the layout's filename. Tests were updated to reflect changes in studio config. A test was written to check that layout files are found from thelayoutsdir.The current
LayoutSlicejust contains astring[]of the names of the layouts in the layouts dir. This is simply a place holder, since no layout parsing was implemented yet. Layout parsing and the LayoutSlice will be fleshed out in future PRs in the epic.J=SLAP-2923
TEST=auto,manual