Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LoadingOverlay for Component And Bundle Loading #388

Merged
merged 20 commits into from
Sep 28, 2023
Merged

Add LoadingOverlay for Component And Bundle Loading #388

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
e856698
wip:
oshi97 Sep 26, 2023
267b625
wip
oshi97 Sep 26, 2023
54fbc7a
wip with new pattern!
oshi97 Sep 26, 2023
1e2b996
formatting
oshi97 Sep 26, 2023
49bf31a
refactor
oshi97 Sep 26, 2023
b8fc081
post rebase
oshi97 Sep 26, 2023
b9cb79a
remove extra frag
oshi97 Sep 26, 2023
db5dcdb
small rename
oshi97 Sep 26, 2023
3163d7c
rename back to App
oshi97 Sep 26, 2023
447a052
Automated linting update and features.json sync
github-actions[bot] Sep 26, 2023
6c9e14c
update tests
oshi97 Sep 26, 2023
f182479
simplify transition time
oshi97 Sep 26, 2023
e0008f6
flip order so overlay doesnt block clicking
oshi97 Sep 27, 2023
b4466b0
tweak things and snapshots
oshi97 Sep 27, 2023
eafb829
Updated snapshots for macos-latest 4 of 4
github-actions[bot] Sep 27, 2023
4aaef49
Updated snapshots for macos-latest 1 of 4
github-actions[bot] Sep 27, 2023
5da2c6b
empty
oshi97 Sep 27, 2023
2bf175f
add local data!
oshi97 Sep 28, 2023
015e831
change message
oshi97 Sep 28, 2023
299f6db
Automated linting update and features.json sync
github-actions[bot] Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...sts/__screenshots__/darwin/add-element.spec.ts/can-add-a-Footer-component-1.png
View file
Open in desktop
alextaing marked this conversation as resolved.
Show resolved Hide resolved
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...sts/__screenshots__/darwin/add-element.spec.ts/can-add-a-Footer-component-2.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...sts/__screenshots__/darwin/add-element.spec.ts/can-add-a-Footer-component-3.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...nshots__/darwin/rearrange-elements.spec.ts/can-rearrange-elements-in-tree-1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/__screenshots__/darwin/viewport-menu.spec.ts/can-set-and-reset-Viewport-1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/__screenshots__/darwin/viewport-menu.spec.ts/can-set-and-reset-Viewport-2.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/__screenshots__/darwin/viewport-menu.spec.ts/can-set-and-reset-Viewport-3.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
30 changes: 15 additions & 15 deletions ...ernal-feature-static-file-generation-BasicPage__en__cfcd208495d565ef66e7dff9f98764da.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"__": {
"name": "BasicPage",
"staticPage": {},
"templateType": "JS"
},
"businessId": 3350634,
"key": "0:BasicPage:knowledgeGraph:0:en",
"locale": "en",
"meta": {
"locale": "en"
},
"siteDomain": "",
"siteId": 0,
"siteInternalHostName": ""
}
"__": {
"name": "BasicPage",
"staticPage": {},
"templateType": "JS"
},
"businessId": 3350634,
"key": "0:BasicPage:knowledgeGraph:0:en",
"locale": "en",
"meta": {
"locale": "en"
},
"siteDomain": "",
"siteId": 0,
"siteInternalHostName": ""
}
30 changes: 15 additions & 15 deletions ...-static-file-generation-ErrorComponentPreviews__en__cfcd208495d565ef66e7dff9f98764da.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"__": {
"name": "ErrorComponentPreviews",
"staticPage": {},
"templateType": "JS"
},
"businessId": 3350634,
"key": "0:ErrorComponentPreviews:knowledgeGraph:0:en",
"locale": "en",
"meta": {
"locale": "en"
},
"siteDomain": "",
"siteId": 0,
"siteInternalHostName": ""
}
"__": {
"name": "ErrorComponentPreviews",
"staticPage": {},
"templateType": "JS"
},
"businessId": 3350634,
"key": "0:ErrorComponentPreviews:knowledgeGraph:0:en",
"locale": "en",
"meta": {
"locale": "en"
},
"siteDomain": "",
"siteId": 0,
"siteInternalHostName": ""
}
16 changes: 16 additions & 0 deletions ...ernal-feature-static-file-generation-ErrorPage__en__cfcd208495d565ef66e7dff9f98764da.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"__": {
"name": "ErrorPage",
"staticPage": {},
"templateType": "JS"
},
"businessId": 3350634,
"key": "0:ErrorPage:knowledgeGraph:0:en",
"locale": "en",
"meta": {
"locale": "en"
},
"siteDomain": "",
"siteId": 0,
"siteInternalHostName": ""
}
16 changes: 0 additions & 16 deletions ...l-feature-static-file-generation-NewStaticPage__en__cfcd208495d565ef66e7dff9f98764da.json
View file
Open in desktop

This file was deleted.

44 changes: 22 additions & 22 deletions e2e-tests/localData/mapping.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
{
"BasicPage": [
"cog-internal-feature-static-file-generation-BasicPage__en__cfcd208495d565ef66e7dff9f98764da.json"
],
"ErrorComponentPreviews": [
"cog-internal-feature-static-file-generation-ErrorComponentPreviews__en__cfcd208495d565ef66e7dff9f98764da.json"
],
"ErrorPage": [
"cog-internal-feature-static-file-generation-ErrorPage__en__cfcd208495d565ef66e7dff9f98764da.json"
],
"LocationPage": [
"studio-stream-id-LocationPage__en__b5c72eb6622ba376c857dbedac25989b.json",
"studio-stream-id-LocationPage__en__c436bc541570239fdbb3c86a549f7a71.json",
"studio-stream-id-LocationPage__en__138daa2e17fc5803f9d87d45899b6bd1.json",
"studio-stream-id-LocationPage__en__74f6cc7a9108951c20122cd3dabb7eb5.json",
"studio-stream-id-LocationPage__en__3a148c2b8fc08ea238566ecbca52ed91.json",
"studio-stream-id-LocationPage__en__7d5f646cf2f84c4ce9ef3a0f92afe207.json",
"studio-stream-id-LocationPage__en__ab9a660c88afbd8dafb14c8c8b281274.json",
"studio-stream-id-LocationPage__en__a09d94986018c82320dfe5e138ea88ef.json",
"studio-stream-id-LocationPage__en__63332cafcabf752f4ecfa57bb7f83e42.json",
"studio-stream-id-LocationPage__en__8f3df878733e5e0969823b81e3bf497f.json"
]
}
"BasicPage": [
"cog-internal-feature-static-file-generation-BasicPage__en__cfcd208495d565ef66e7dff9f98764da.json"
],
"ErrorComponentPreviews": [
"cog-internal-feature-static-file-generation-ErrorComponentPreviews__en__cfcd208495d565ef66e7dff9f98764da.json"
],
"ErrorPage": [
"cog-internal-feature-static-file-generation-ErrorPage__en__cfcd208495d565ef66e7dff9f98764da.json"
],
"LocationPage": [
"studio-stream-id-LocationPage__en__b5c72eb6622ba376c857dbedac25989b.json",
"studio-stream-id-LocationPage__en__c436bc541570239fdbb3c86a549f7a71.json",
"studio-stream-id-LocationPage__en__138daa2e17fc5803f9d87d45899b6bd1.json",
"studio-stream-id-LocationPage__en__74f6cc7a9108951c20122cd3dabb7eb5.json",
"studio-stream-id-LocationPage__en__3a148c2b8fc08ea238566ecbca52ed91.json",
"studio-stream-id-LocationPage__en__7d5f646cf2f84c4ce9ef3a0f92afe207.json",
"studio-stream-id-LocationPage__en__ab9a660c88afbd8dafb14c8c8b281274.json",
"studio-stream-id-LocationPage__en__a09d94986018c82320dfe5e138ea88ef.json",
"studio-stream-id-LocationPage__en__63332cafcabf752f4ecfa57bb7f83e42.json",
"studio-stream-id-LocationPage__en__8f3df878733e5e0969823b81e3bf497f.json"
]
}
220 changes: 113 additions & 107 deletions e2e-tests/localData/studio-stream-id-LocationPage__en__138daa2e17fc5803f9d87d45899b6bd1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,108 +1,114 @@
{
"__": {
"entityPageSet": {},
"name": "LocationPage",
"streamId": "studio-stream-id-LocationPage",
"templateType": "JS"
},
"address": {
"city": "London",
"countryCode": "GB",
"line1": "48 Warwick St.",
"line2": "Office 410",
"localizedCountryName": "United Kingdom",
"localizedRegionName": "City of London",
"postalCode": "W1B 5AW",
"region": "Gt Lon"
},
"addressHidden": false,
"businessId": 3350634,
"c_features": ["OPEN_NOW"],
"cityCoordinate": {
"latitude": 51.50642013549805,
"longitude": -0.12721000611782074
},
"description": "Yext is the global digital knowledge management leader, and our Knowledge Engine puts businesses in control of their digital knowledge.",
"displayCoordinate": {
"latitude": 51.5107139,
"longitude": -0.1377914
},
"geocodedCoordinate": {
"latitude": 51.5106898,
"longitude": -0.1378107
},
"hours": {
"friday": {
"isClosed": true
},
"monday": {
"isClosed": true
},
"saturday": {
"isClosed": true
},
"sunday": {
"isClosed": true
},
"thursday": {
"isClosed": true
},
"tuesday": {
"openIntervals": [
{
"end": "16:00",
"start": "15:00"
}
]
},
"wednesday": {
"isClosed": true
}
},
"id": "7941089580646240971",
"isoRegionCode": "LND",
"key": "0:LocationPage:knowledgeGraph:18714999:en",
"locale": "en",
"mainPhone": "+442037052290",
"meta": {
"entityType": {
"id": "location",
"uid": 0
},
"locale": "en"
},
"name": "Office Space",
"priceRange": "FOUR",
"ref_categories": [
{
"id": "668",
"name": "Software Consultant",
"uid": 668
}
],
"ref_listings": [],
"ref_reviewsAgg": [],
"routableCoordinate": {
"latitude": 51.51076,
"longitude": -0.13767
},
"services": ["Dogs", "Cats", "Sleep"],
"siteDomain": "",
"siteId": 0,
"siteInternalHostName": "",
"slug": "office/7941089580646240971",
"timezone": "Europe/London",
"uid": 18714999,
"websiteUrl": {
"preferDisplayUrl": false,
"url": "https://locations.yext.com/gb/gt-lon/london/48-warwick-st-.html"
},
"yextDisplayCoordinate": {
"latitude": 51.5107139,
"longitude": -0.1377914
},
"yextRoutableCoordinate": {
"latitude": 51.51076,
"longitude": -0.13767
}
}
"__": {
"entityPageSet": {},
"name": "LocationPage",
"streamId": "studio-stream-id-LocationPage",
"templateType": "JS"
},
"address": {
"city": "London",
"countryCode": "GB",
"line1": "48 Warwick St.",
"line2": "Office 410",
"localizedCountryName": "United Kingdom",
"localizedRegionName": "City of London",
"postalCode": "W1B 5AW",
"region": "Gt Lon"
},
"addressHidden": false,
"businessId": 3350634,
"c_features": [
"OPEN_NOW"
],
"cityCoordinate": {
"latitude": 51.50642013549805,
"longitude": -0.12721000611782074
},
"description": "Yext is the global digital knowledge management leader, and our Knowledge Engine puts businesses in control of their digital knowledge.",
"displayCoordinate": {
"latitude": 51.5107139,
"longitude": -0.1377914
},
"geocodedCoordinate": {
"latitude": 51.5106898,
"longitude": -0.1378107
},
"hours": {
"friday": {
"isClosed": true
},
"monday": {
"isClosed": true
},
"saturday": {
"isClosed": true
},
"sunday": {
"isClosed": true
},
"thursday": {
"isClosed": true
},
"tuesday": {
"openIntervals": [
{
"end": "16:00",
"start": "15:00"
}
]
},
"wednesday": {
"isClosed": true
}
},
"id": "7941089580646240971",
"isoRegionCode": "LND",
"key": "0:LocationPage:knowledgeGraph:18714999:en",
"locale": "en",
"mainPhone": "+442037052290",
"meta": {
"entityType": {
"id": "location",
"uid": 0
},
"locale": "en"
},
"name": "Office Space",
"priceRange": "FOUR",
"ref_categories": [
{
"id": "668",
"name": "Software Consultant",
"uid": 668
}
],
"ref_listings": [],
"ref_reviewsAgg": [],
"routableCoordinate": {
"latitude": 51.51076,
"longitude": -0.13767
},
"services": [
"Dogs",
"Cats",
"Sleep"
],
"siteDomain": "",
"siteId": 0,
"siteInternalHostName": "",
"slug": "office/7941089580646240971",
"timezone": "Europe/London",
"uid": 18714999,
"websiteUrl": {
"preferDisplayUrl": false,
"url": "https://locations.yext.com/gb/gt-lon/london/48-warwick-st-.html"
},
"yextDisplayCoordinate": {
"latitude": 51.5107139,
"longitude": -0.1377914
},
"yextRoutableCoordinate": {
"latitude": 51.51076,
"longitude": -0.13767
}
}
Loading
Loading