Add an Info Icon for Props with a Tooltip. #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanu1
reviewed
Oct 10, 2023
nmanu1
reviewed
Oct 10, 2023
alextaing
approved these changes
Oct 10, 2023
alextaing
pushed a commit
that referenced
this pull request
Oct 10, 2023
This PR adds an Info icon to the right of the Prop Name when the Prop has a Tooltip. The anchor of the Tooltip is now the Info Icon. To do this, I created a new common Component called TooltipIcon representing the combination of an `Icon` and a `Tooltip`. I added visual regression coverage for Prop Tooltips as well, we were missing it. J=SLAP-2952 TEST=auto
alextaing
pushed a commit
that referenced
this pull request
Oct 10, 2023
This PR adds an Info icon to the right of the Prop Name when the Prop has a Tooltip. The anchor of the Tooltip is now the Info Icon. To do this, I created a new common Component called TooltipIcon representing the combination of an `Icon` and a `Tooltip`. I added visual regression coverage for Prop Tooltips as well, we were missing it. J=SLAP-2952 TEST=auto
Merged
tmeyer2115
added a commit
that referenced
this pull request
Oct 11, 2023
## Features - When specifying a Component's Prop Interface, you can now use the `extends` keyword. (#395) ## Changes - Cached, pre-bundled dependencies are now ignored when starting Studio. Studio's Vite instance will pre-bundle all dependencies each time Studio is started. (#405) - Props with a Tooltip now have an Info Icon (#403) ## Fixes - Incorrect imports for commonly-named Components have been fixed. (#398)
alextaing
pushed a commit
that referenced
this pull request
Oct 11, 2023
## Features - When specifying a Component's Prop Interface, you can now use the `extends` keyword. (#395) ## Changes - Cached, pre-bundled dependencies are now ignored when starting Studio. Studio's Vite instance will pre-bundle all dependencies each time Studio is started. (#405) - Props with a Tooltip now have an Info Icon (#403) ## Fixes - Incorrect imports for commonly-named Components have been fixed. (#398)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Info icon to the right of the Prop Name when the Prop has a Tooltip. The anchor of the Tooltip is now the Info Icon. To do this, I created a new common Component called TooltipIcon representing the combination of an
Iconand aTooltip. I added visual regression coverage for Prop Tooltips as well, we were missing it.J=SLAP-2952
TEST=auto