add support for json/yaml output to list #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
approved these changes
Jan 27, 2023
cmd/promlinter/main.go
Outdated
| @@ -58,6 +60,7 @@ func main() { | |||
| Default("false").Short('s').Bool() | |||
| listPrintAddPos := listCmd.Flag("add-position", "Add metric position column when printing the result.").Default("false").Bool() | |||
| listPrintAddHelp := listCmd.Flag("add-help", "Add metric help column when printing the result.").Default("false").Bool() | |||
| listPrintJSON := listCmd.Flag("json", "Print result as json.").Default("false").Bool() | |||
There was a problem hiding this comment.
Instead of a bool for printing out using json format, what do you think about having an output flag as a string to be extensible to support different formats like json, markdown, etc
|
Sounds like a good idea. Let me check if i can add support for the other usual suspect (yaml). |
k15r
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to print the output of list in json format.
The format is quite handy it you want to process further e.g. during generation of documentation.
use
-oyaml/--ojson--output= ...