Add support for peer discovery over BLE #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news ? @aakselrod this app is great |
If @Revertron wants, I'm happy to rebase and respond to any comments. |
|
is there an ios pr for android <> ios ble peer disco? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for peer discovery over BLE. It does the following:
This PR depends on yggdrasil-network/yggdrasil-go#1063. There is a build based on this PR at https://github.com/aakselrod/yggdrasil-android/releases/tag/f4ba96b which has an additional commit allowing GitHub to build the app with the underlying Golang changes. The underlying changes allow the app to request that the mobile bindings also listen on a static TCP port, which the app does for TCP 9004 on the loopback interface. The build is good for a demo, but uses my own (temporary) keys to package the APK.