-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add init, del, repr, doc for pyType #308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Destroy hooks should already work with regular nim machinery, i.e. =destroy()
hooks. If they don't it should be fixed, but no additional conventions should be invented.
Also please use 2 spaces indentation wherever you're using 4.
I saw that you bind tp_free, tp_dealloc here Lines 154 to 160 in 0645af5
However, tp_finalize is a separate function (called before tp_dealloc) (del in python). If someone has some extra memory management need be done before destroy the object. tp_finalize is the function to call. |
I don't understand what's so valuable in the finalize callback vs nim destructors that justifies it, despite the fact that |
Ok. |
Thank you! |
Hi @yglukhov , please pull the following merge request.
implement init, del, doc for exported types
Example
fix the CI/CD pipeline
Logs
made some minor changes on the readme file