Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emscripten #452

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix emscripten #452

wants to merge 7 commits into from

Conversation

capocasa
Copy link
Contributor

@capocasa capocasa commented Dec 9, 2020

This is more to document progress- unsure how to proceed

I started fixing bugs on emscripten when I realized it would probably have worked with an earlier version, but decided to continue anyway

These work with emscripten 2.0.9 and contain backwords incompatible changes. See also yglukhov/jsbind#14

@yglukhov
Copy link
Owner

Hey @capocasa. What's the status of this? Is it still WIP?

@capocasa
Copy link
Contributor Author

capocasa commented Dec 21, 2020

@yglukhov: It works for latest emscripten but breaks compatibility with older emscripten

You could

(a) accept merge into master, accept dependency change to newer emscripten version, update emscripten version in CI,

(b) accept merge into a new_emscripten dev branch, keep old emscripten version in master

@capocasa capocasa marked this pull request as ready for review December 21, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants