Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <Input> type variants url, email, and number #279

Merged
merged 6 commits into from
Oct 29, 2022
Merged

Conversation

yhatt
Copy link
Owner

@yhatt yhatt commented Oct 29, 2022

Extend type prop variants for <Input> component, to support URL input, email input, and number input. Slack app can provide proper input elements for purpose.

<Modal title="Input variants">
  <Input type="text" label="Text" />
  <Input type="url" label="URL" />
  <Input type="email" label="Email" />
  <Input type="number" label="Number" min={0} max={1000} />
</Modal>

Input variants

This interface is very similar to jsx-slack v0's (outdated) dialog support.
https://github.com/yhatt/jsx-slack/blob/v0.11.0/docs/jsx-components-for-dialog.md#html5-types

Close #277.

ToDo

  • Add <Input> type variants url, email, and number
  • Update schema for demo
  • Tests
  • Documentations

@yhatt yhatt merged commit 2d919a9 into main Oct 29, 2022
@yhatt yhatt deleted the input-type-variations branch October 29, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<input type> variants support
1 participant