New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support types field of conditional exports #290

Merged

yhatt merged 1 commit into yhatt:main from odanado:support-conditional-export-types

Feb 19, 2023

Contributor

odanado commented Feb 19, 2023

Thank you great library!

--moduleResolution node16 or --moduleResolution nodenext with tsc will resolve the types field of the exports field of the npm package.

"types" - can be used by typing systems to resolve the typing file for the given export. This condition should always be included first.
https://nodejs.org/api/packages.html#community-conditions-definitions

If the types field is not specified, import "jsx-slack" will result in a type error.

reproduced repository
https://github.com/odan-sandbox/jsx-slack-node-esm-sandbox


          add types field in exports

e4b6e32

yhatt approved these changes

View reviewed changes

Owner

yhatt left a comment

Thanks! 👍

yhatt merged commit 369f2e4 into yhatt:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet