Fix JSXSlack.Children.toArray to make flatten children correctly even if caused dual import of <Fragment>
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponent to make flatten children by using `JSXSlack.Children.toArray`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#319 reports
<Fragment>can include in<Section>but<>cannot. Why?JSXSlack.Children.toArraymakes flatten children in<Fragment>component, but jsx-slack will check the equality ofFragmentfunction by using only a function inJSXSlacknamespace, in spite ofFragmentin JSX runtime (<>) and inJSXSlacknamespace (<JSXSlack.Fragment>) may point each different functions.So the children of
<Section>cannot make flatten<></>correctly, and remains<>in the normalized children, that is not supposed to exist, and<Section>component denies that as children.This PR changes the
<Fragment>detection to use the name of built-in component instead of the function itself.