Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Implement "Reopen with Encoding" command in File menu #53

Merged
merged 1 commit into from
Jul 30, 2016

Conversation

yhatt
Copy link
Owner

@yhatt yhatt commented Jul 23, 2016

It has mentioned in #22. I added Reopen with Encoding command to File menu.

  • Reopen with Encoding is disabled in new document, and it's enabled in existed file.
  • When you click menu-item of the encoding, an opened file will re-open from disk.
  • If you have edited buffer, Marp asks whether re-opening.

Implemented encoding which have organized menu-items by country groups are based on atom/encoding-selector.

Screen cast

marp

@yhatt
Copy link
Owner Author

yhatt commented Jul 23, 2016

Additional: Selected encoding doesn't apply on save because we had planned to use encoding UTF-8 for save.

@will-hart
Copy link
Contributor

Will this also address #39 and #46?

@yhatt
Copy link
Owner Author

yhatt commented Jul 24, 2016

No. These issue was brought by the rendered font as said on #39. I'll create another pull request for these.

@yhatt yhatt merged commit e6cae86 into master Jul 30, 2016
@yhatt yhatt deleted the reopen-with-encoding branch July 30, 2016 12:25
@yhatt yhatt mentioned this pull request Jul 30, 2016
@DivineDominion
Copy link

Fixes #73! Great.

Is there no way to detect the file's encoding and use it by default?

@yhatt
Copy link
Owner Author

yhatt commented Oct 2, 2016

Actually, Marp already detects text encoding whenever opening file. (Powered by jschardet)

But it has edge-cases to fail when text file encoded by UTF-8 includes umlauts. This feature made for deal with it. Please see #22 and #59.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants