This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Remove Japanese font definition (Fix #85) #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/w speficied update of github-markdown-css
/w emoji support by Apple and Microsoft fonts
yhatt
commented
Oct 2, 2016
| font-size: 29px | ||
|
|
||
| tt, code | ||
| font-family: 'SourceHanCodeJP-Normal', 'Ricty', Consolas, "Liberation Mono", Menlo, Courier, monospace |
There was a problem hiding this comment.
Removed font-family definition from default theme. These definition would be delegated to github-markdown-css.
| @@ -11,7 +11,7 @@ class MdsConfig | |||
|
|
|||
| @initialConfig: | |||
| editor: | |||
| fontFamily: 'Osaka-mono, "MS Gothic", monospace' | |||
| fontFamily: 'Consolas, monaco, monospace' | |||
There was a problem hiding this comment.
I want to discuss this.
I removed Japanese font from editor's font, and added monospace fonts: Consolas for Windows, and Monaco for Mac.
However, only monospace would work well from the point of internationalize.
yhatt
commented
Oct 8, 2016
This was referenced Oct 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For internationalize, I removed Japanese fonts from
font-familydefinitions on theme / editor. This would fix issue #85.And the emoji font is specified in theme CSS. Although I do not verify, it might fix #57.