Fix CPPHTTPLIB_ALLOW_LF_AS_LINE_TERMINATOR #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrexodia thanks for find the bug! Could you leave |
|
@mrexodia if you are busy to make the above change, I can handle it directly in the master branch. Please let me know . Thanks! |
|
Force pushed the change as you suggested just now. Thanks for the reminder! |
|
And thanks again for making this library. I use it quite often! |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In e5cacb4 this issue was supposedly fixed, but in fact it introduced a bug and implemented it the wrong way.
The
\r?is the default code path instead of specialized withCPPHTTPLIB_ALLOW_LF_AS_LINE_TERMINATORas it should be.In my opinion this behavior should be opt-out instead of opt-in (to match curl, which doesn't require any special options either) but that's probably something to discuss another time.