Automatically redirect http://host/folder to http://host/folder/ #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will then automatically look for the /index.html file.
|
I wonder if #1848 will also be fixed with this? |
sergio-nsk
reviewed
Sep 2, 2024
Comment on lines
6475
to
+6477
| if (path.back() == '/') { path += "index.html"; } | ||
|
|
||
| if (detail::is_dir(path)) { |
There was a problem hiding this comment.
Then it should also have the opposite part
Suggested change
| if (path.back() == '/') { path += "index.html"; } | |
| if (detail::is_dir(path)) { | |
| if (path.back() == '/') { | |
| path.pop_back(); | |
| if (detail::is_file(path)) { | |
| sub_path.pop_back(); | |
| res.set_redirect(sub_path); | |
| return true; | |
| } | |
| path += "/index.html"; } | |
| } else if (detail::is_dir(path)) { |
There was a problem hiding this comment.
NGINX doesn't redirect file to file/ either, but returns as 404.
|
@paulharris could you please provide at least one unit test case in |
|
@paulharris I added some test cases and adjust your code to return 301 instead of 302. Thanks for your contribution! |
|
My apologies for the late reply, it was circling back to this but I'm very happy that you liked it and cleaned it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will then automatically look for the /index.html file.
This fixes #1389