Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yieldmo adapter: support for the floors module #9

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion modules/yieldmoBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ function openRtbImpression(bidRequest) {
const imp = {
id: bidRequest.bidId,
tagid: bidRequest.adUnitCode,
bidfloor: bidRequest.params.bidfloor || 0,
bidfloor: getBidFloor(bidRequest),
ext: {
placement_id: bidRequest.params.placementId
},
Expand All @@ -304,6 +304,16 @@ function openRtbImpression(bidRequest) {
return imp;
}

function getBidFloor(bidRequest) {
let floorInfo = {};

if (typeof bidRequest.getFloor === 'function') {
floorInfo = bidRequest.getFloor({ currency: CURRENCY, mediaType: VIDEO, size: '*' });
}

return floorInfo.floor || bidRequest.params.bidfloor || 0;
}

/**
* @param {BidRequest} bidRequest bidder request object.
* @return [number, number] || null Player's width and height, or undefined otherwise.
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 28 additions & 1 deletion test/spec/modules/yieldmoBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ describe('YieldmoAdapter', function () {
...params
});

const mockGetFloor = floor => ({getFloor: () => ({ currency: 'USD', floor })});

describe('isBidRequestValid', function () {
describe('Banner:', function () {
it('should return true when necessary information is found', function () {
Expand Down Expand Up @@ -259,12 +261,37 @@ describe('YieldmoAdapter', function () {
});

describe('Instream video:', function () {
it('should attempt to send banner bid requests to the endpoint via POST', function () {
it('should attempt to send video bid requests to the endpoint via POST', function () {
const requests = build([mockVideoBid()]);
expect(requests.length).to.equal(1);
expect(requests[0].method).to.equal('POST');
expect(requests[0].url).to.be.equal(VIDEO_ENDPOINT);
});

it('should process floors module if available', function () {
const requests = build([
mockVideoBid({...mockGetFloor(3.99)}),
mockVideoBid({...mockGetFloor(1.23)}, { bidfloor: 1.1 }),
]);
const imps = requests[0].data.imp;
expect(imps[0].bidfloor).to.equal(3.99);
expect(imps[1].bidfloor).to.equal(1.23);
});

it('should use bidfloor if no floors module is available', function() {
const requests = build([
mockVideoBid({}, { bidfloor: 1.2 }),
mockVideoBid({}, { bidfloor: 0.7 }),
]);
const imps = requests[0].data.imp;
expect(imps[0].bidfloor).to.equal(1.2);
expect(imps[1].bidfloor).to.equal(0.7);
});

it('should have 0 bidfloor value by default', function() {
const requests = build([mockVideoBid()]);
expect(requests[0].data.imp[0].bidfloor).to.equal(0);
});
});
});

Expand Down