Update index.jsx #371
Update index.jsx #371
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/components/RunMap/index.jsx
Outdated
| @@ -16,6 +16,10 @@ import RunMarker from './RunMaker'; | |||
| import RunMapButtons from './RunMapButtons'; | |||
| import styles from './style.module.scss'; | |||
|
|
|||
| //change 'dispaly' to 'hide' if you want to hide the road label; | |||
| const RoadLabelDisplay = 'display'; | |||
There was a problem hiding this comment.
changed to 'true' and 'false'
There was a problem hiding this comment.
not that way, you are still using string.
There was a problem hiding this comment.
sorry, not string this time
src/components/RunMap/index.jsx
Outdated
| const RoadLabelDisplay = true; | ||
| const layerList=['road-label', 'waterway-label', 'natural-line-label', 'natural-point-label', 'water-line-label', 'water-point-label', 'poi-label', 'airport-label', 'settlement-subdivision-label', 'settlement-label', 'state-label', 'country-label']; |
There was a problem hiding this comment.
move this to config file like we did maybe better
src/components/RunMap/index.jsx
Outdated
| @@ -34,6 +38,13 @@ const RunMap = ({ | |||
| const map = ref.getMap(); | |||
| if (map && IS_CHINESE) { | |||
| map.addControl(new MapboxLanguage({ defaultLanguage: 'zh-Hans' })); | |||
| if (RoadLabelDisplay == false) { | |||
src/components/RunMap/index.jsx
Outdated
| for(let layerId of layerList){ | ||
| map.removeLayer(layerId); |
There was a problem hiding this comment.
can we use layerList.forEach((layerId) => {map.removeLayer(layerId)})
src/components/RunMap/index.jsx
Outdated
| map.on('load', () => { | ||
| MAP_LAYER_LIST.forEach((layerId) => {map.removeLayer(layerId)}) |
There was a problem hiding this comment.
make it looks better and it works fine, but i don't it's right or not
i tested both locally and they both worked fine, now i run the pulled version in vercel for two days it seems ok too |
|
OK will merge tonight or tomorrow after test |
|
@lingdeyiyicifang thanks a lot |
Update index.jsx
make road label hideable, display road label in default.