Fix codoon and Upload tcx_to_garmin #662

Vensent · 2024-04-19T17:34:06Z

Fix the tcx format in codoon_sync.py
Add tcx_sync_garmin.py
Add oppo_sync.py, while currently not work.

Closes #645

also modify some format problem when uploading the tcx file export from codoon.

vercel · 2024-04-19T17:34:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
running-page	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 22, 2024 4:25pm

yihong0618 · 2024-04-20T04:53:58Z

nice pr will take a look tonight

yihong0618

nice code

yihong0618 · 2024-04-20T04:52:50Z

run_page/codoon_sync.py

+    activity_creator = ET.Element(
+        "Creator",
+        {
+            "xsi:type": "Device_t"


能取个更有表示点的名字么？

能取个更有表示点的名字么？

我打开佳明的tcx这部分长这样：

<Creator xsi:type="Device_t"> <Name>Forerunner 945</Name> <UnitId>********</UnitId> <ProductID>****</ProductID> <Version> <VersionMajor>13</VersionMajor> <VersionMinor>0</VersionMinor> <BuildMajor>0</BuildMajor> <BuildMinor>0</BuildMinor> </Version> </Creator>

应该不能改成其他的样子了。

yihong0618 · 2024-04-20T13:57:57Z

.github/workflows/run_data_sync.yml

+      - name: Run sync Oppo heytap script, note currently this script is not worked
+        if: env.RUN_TYPE == 'oppo'
+        run: |
+            python run_page/oppo_sync.py ${{ secrets.OPPO_ID }} ${{ secrets.OPPO_CLIENT_SECRET }} ${{ secrets.OPPO_CLIENT_REFRESH_TOKEN }} --with-tcx


we do not support gpx right?

we do not support gpx right?

代码可以先放上来，现在内部消息是这个oppo heytap健康的数据暂时还没有完全对外开放，不过在计划中了。我的代码是--with-tcx、--with-gpx都可以的。需要更新一下说明不？

yihong0618 · 2024-04-20T13:58:45Z

run_page/codoon_sync.py

+    xmlstr = minidom.parseString(ET.tostring(training_center_database)).toprettyxml(indent="  ", encoding="UTF-8")
+    with open(TCX_FOLDER + "/" + fit_id + ".tcx", "w") as f:
+        f.write(str(xmlstr.decode("UTF-8")))
+        f.close()


do not need close here

do not need close here

python里面写文件的流最后不用关么？因为我平时用java多一点，写完流必须要关。。

got reference here

with statements handle the close automatically

ben-29

Please fix the lint using black to pass the CI

ben-29 · 2024-04-21T10:55:38Z

run_page/codoon_sync.py

+    xmlstr = minidom.parseString(ET.tostring(training_center_database)).toprettyxml(indent="  ", encoding="UTF-8")
+    with open(TCX_FOLDER + "/" + fit_id + ".tcx", "w") as f:
+        f.write(str(xmlstr.decode("UTF-8")))
+        f.close()


with statements handle the close automatically

ben-29 · 2024-04-21T11:14:32Z

run_page/codoon_sync.py

+    author_lang.text = "en"
+    author.append(author_lang)
+    author_part = ET.Element("PartNumber")
+    author_part.text = "006-D2449-00"


Extract this string to a variable and leave a comment specifying which Garmin device it is for.

scope: subject:

Vensent · 2024-04-22T04:46:11Z

Let me check it locally before submitting PR again.

yihong0618 · 2024-04-22T05:50:38Z

Let me check it locally before submitting PR again.

just continue commit is Ok~~

Vensent · 2024-04-22T16:28:26Z

Please review again. Thx @yihong0618 @ben-29

ben-29 · 2024-04-23T12:58:43Z

run_page/tcx_to_garmin_sync.py

+    """
+    file_names = os.listdir(TCX_FOLDER)
+    tcx = TCXReader()
+    tcx_files = [


What happens if the TCX_FOLDER is empty?

Vensent · 2024-04-23T13:21:06Z

run_page/tcx_to_garmin_sync.py

+
+
+if __name__ == "__main__":
+    if not os.path.exists(TCX_FOLDER):


@ben-29 Please have a look at here. If TCX_FOLDER does not exit, we'll create first.

Vensent · 2024-04-23T13:22:07Z

run_page/tcx_to_garmin_sync.py

+
+    dict(sorted(tcx_files_dict.items()))
+
+    return tcx_files_dict.values()


if the TCX_FOLDER is empty, we'll get an empty result. And it's OK. @ben-29

ben-29 · 2024-04-23T13:53:52Z

LGTM

yihong0618

Nice job

* yihong0618-master: (33 commits) Fix codoon and Upload tcx_to_garmin (yihong0618#662) Update README-CN.md (yihong0618#663) add keep2strava (yihong0618#653) Add data to 'running page runners' table (yihong0618#656) style: use Tailwind CSS (yihong0618#655) feat: fill country (yihong0618#654) docs: add runner (yihong0618#651) doc: add new runner docs: update README (yihong0618#650) docs: add a comment in `src/utils/consts.ts` to remind about security considerations regarding the `MAPBOX_TOKEN` (yihong0618#644) fix: no package manager fix: tachyons-sass import error (yihong0618#639) Update README.md (yihong0618#638) Add proxy config, add keep config, change npm registry, use yarn (yihong0618#634) chore: fix typo (yihong0618#633) chore: Update package manager and ignore requirements-dev.txt (yihong0618#632) add run.drink.cafe (yihong0618#628) feat: coros sync (yihong0618#623) Fix README typo (yihong0618#624) fix: ts type error (yihong0618#622) ...

* refs/heads/upstream: (71 commits) Add laqieer's running page to README (yihong0618#672) chore: add raycast extension support (yihong0618#670) add </details> (yihong0618#669) fix the deprecation warning (yihong0618#668) Fix codoon and Upload tcx_to_garmin (yihong0618#662) Update README-CN.md (yihong0618#663) add keep2strava (yihong0618#653) Add data to 'running page runners' table (yihong0618#656) style: use Tailwind CSS (yihong0618#655) feat: fill country (yihong0618#654) docs: add runner (yihong0618#651) doc: add new runner docs: update README (yihong0618#650) docs: add a comment in `src/utils/consts.ts` to remind about security considerations regarding the `MAPBOX_TOKEN` (yihong0618#644) fix: no package manager fix: tachyons-sass import error (yihong0618#639) Update README.md (yihong0618#638) Add proxy config, add keep config, change npm registry, use yarn (yihong0618#634) chore: fix typo (yihong0618#633) chore: Update package manager and ignore requirements-dev.txt (yihong0618#632) ... # Conflicts: # run_page/gpxtrackposter/track.py # run_page/keep_sync.py

* add oppo_sync and tcx_to_garmin.py also modify some format problem when uploading the tcx file export from codoon. * 修改readme.md * 修复CI遇到的问题，已经根据评审修改相关的代码 * 解决运行时参数少了的异常 * Optimise the lap details in tcx file. * type: 修改漏掉的文件 scope: subject: * 完善代码逻辑 * 修改代码漏洞 * 修改oppo的请求接口地址 * 解决编译问题 * 解决咕咚tcx生成异常问题，同时解决当前存在的CI问题 * 使用black完成代码format

Vensent added 2 commits April 20, 2024 01:21

add oppo_sync and tcx_to_garmin.py

d292d8b

also modify some format problem when uploading the tcx file export from codoon.

修改readme.md

f62d37e

vercel bot deployed to Preview April 19, 2024 17:35 View deployment

yihong0618 requested a review from ben-29 April 20, 2024 04:54

yihong0618 reviewed Apr 20, 2024

View reviewed changes

ben-29 reviewed Apr 21, 2024

View reviewed changes

修复CI遇到的问题，已经根据评审修改相关的代码

6725c80

vercel bot deployed to Preview April 21, 2024 14:46 View deployment

解决运行时参数少了的异常

670ac72

vercel bot deployed to Preview April 21, 2024 14:54 View deployment

Optimise the lap details in tcx file.

747044c

vercel bot deployed to Preview April 21, 2024 15:43 View deployment

Vensent added 5 commits April 22, 2024 00:17

type: 修改漏掉的文件

b565fda

scope: subject:

完善代码逻辑

7f50f69

修改代码漏洞

76f7614

修改oppo的请求接口地址

3180f5a

解决编译问题

adeb849

Vensent closed this Apr 22, 2024

yihong0618 reopened this Apr 22, 2024

Vensent added 2 commits April 22, 2024 23:51

解决咕咚tcx生成异常问题，同时解决当前存在的CI问题

4da3f6d

使用black完成代码format

200813d

vercel bot deployed to Preview April 22, 2024 16:25 View deployment

ben-29 reviewed Apr 23, 2024

View reviewed changes

Vensent commented Apr 23, 2024

View reviewed changes

ben-29 approved these changes Apr 24, 2024

View reviewed changes

yihong0618 approved these changes Apr 24, 2024

View reviewed changes

yihong0618 merged commit c91c325 into yihong0618:master Apr 24, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix codoon and Upload tcx_to_garmin #662

Fix codoon and Upload tcx_to_garmin #662

Vensent commented Apr 19, 2024 •

edited

Loading

vercel bot commented Apr 19, 2024 •

edited

Loading

yihong0618 commented Apr 20, 2024

yihong0618 left a comment

yihong0618 Apr 20, 2024

Vensent Apr 20, 2024 •

edited

Loading

yihong0618 Apr 20, 2024

Vensent Apr 20, 2024

yihong0618 Apr 20, 2024

Vensent Apr 20, 2024

Vensent Apr 20, 2024

ben-29 Apr 21, 2024

ben-29 left a comment

ben-29 Apr 21, 2024

ben-29 Apr 21, 2024

Vensent commented Apr 22, 2024

yihong0618 commented Apr 22, 2024

Vensent commented Apr 22, 2024

ben-29 Apr 23, 2024

Vensent Apr 23, 2024

Vensent Apr 23, 2024

ben-29 commented Apr 23, 2024

yihong0618 left a comment



		if __name__ == "__main__":
		if not os.path.exists(TCX_FOLDER):


		dict(sorted(tcx_files_dict.items()))

		return tcx_files_dict.values()

Fix codoon and Upload tcx_to_garmin #662

Fix codoon and Upload tcx_to_garmin #662

Conversation

Vensent commented Apr 19, 2024 • edited Loading

vercel bot commented Apr 19, 2024 • edited Loading

yihong0618 commented Apr 20, 2024

yihong0618 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vensent Apr 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ben-29 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vensent commented Apr 22, 2024

yihong0618 commented Apr 22, 2024

Vensent commented Apr 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ben-29 commented Apr 23, 2024

yihong0618 left a comment

Choose a reason for hiding this comment

Vensent commented Apr 19, 2024 •

edited

Loading

vercel bot commented Apr 19, 2024 •

edited

Loading

Vensent Apr 20, 2024 •

edited

Loading