Problem: memiavl get benchmark not compare with unordered containers (c…

…rypto-org-chain#939) Solution: - add lru-cache and go-map to the benchmark game
yihuang · Mar 20, 2023 · bd7251b · bd7251b
1 parent f7c6f73
commit bd7251b
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 22 deletions.
diff --git a/memiavl/benchmark_test.go b/memiavl/benchmark_test.go
@@ -6,6 +6,7 @@ import (
  "math/rand"
  "testing"
 
+ lru "github.com/hashicorp/golang-lru"
  "github.com/stretchr/testify/require"
  "github.com/tidwall/btree"
 )
@@ -18,7 +19,8 @@ func BenchmarkByteCompare(b *testing.B) {
 }
 
 func BenchmarkRandomGet(b *testing.B) {
- items := genRandItems(1000000)
+ amount := 1000000
+ items := genRandItems(amount)
  targetKey := items[500].key
  targetValue := items[500].value
  targetItem := itemT{key: targetKey}
@@ -28,24 +30,8 @@ func BenchmarkRandomGet(b *testing.B) {
  tree.Set(item.key, item.value)
  }
 
- bt2 := btree.NewBTreeGOptions(lessG, btree.Options{
- NoLocks: true,
- Degree: 2,
- })
- for _, item := range items {
- bt2.Set(item)
- }
-
- bt32 := btree.NewBTreeGOptions(lessG, btree.Options{
- NoLocks: true,
- Degree: 32,
- })
- for _, item := range items {
- bt32.Set(item)
- }
-
  snapshotDir := b.TempDir()
- err := tree.WriteSnapshot(snapshotDir, false)
+ err := tree.WriteSnapshot(snapshotDir, true)
  require.NoError(b, err)
  snapshot, err := OpenSnapshot(snapshotDir)
  require.NoError(b, err)
@@ -55,10 +41,6 @@ func BenchmarkRandomGet(b *testing.B) {
  require.Equal(b, targetValue, tree.Get(targetKey))
  require.Equal(b, targetValue, diskTree.Get(targetKey))
  require.Equal(b, targetValue, snapshot.Get(targetKey))
- v, _ := bt2.Get(targetItem)
- require.Equal(b, targetValue, v.value)
- v, _ = bt32.Get(targetItem)
- require.Equal(b, targetValue, v.value)
 
  b.ResetTimer()
  b.Run("memiavl", func(b *testing.B) {
@@ -77,15 +59,64 @@ func BenchmarkRandomGet(b *testing.B) {
  }
  })
  b.Run("btree-degree-2", func(b *testing.B) {
+ bt2 := btree.NewBTreeGOptions(lessG, btree.Options{
+ NoLocks: true,
+ Degree: 2,
+ })
+ for _, item := range items {
+ bt2.Set(item)
+ }
+ v, _ := bt2.Get(targetItem)
+ require.Equal(b, targetValue, v.value)
+
+ b.ResetTimer()
  for i := 0; i < b.N; i++ {
  _, _ = bt2.Get(targetItem)
  }
  })
  b.Run("btree-degree-32", func(b *testing.B) {
+ bt32 := btree.NewBTreeGOptions(lessG, btree.Options{
+ NoLocks: true,
+ Degree: 32,
+ })
+ for _, item := range items {
+ bt32.Set(item)
+ }
+ v, _ := bt32.Get(targetItem)
+ require.Equal(b, targetValue, v.value)
+
+ b.ResetTimer()
  for i := 0; i < b.N; i++ {
  _, _ = bt32.Get(targetItem)
  }
  })
+ b.Run("lru-cache", func(b *testing.B) {
+ cache, err := lru.NewARC(amount)
+ require.NoError(b, err)
+ for _, item := range items {
+ cache.Add(string(item.key), item.value)
+ }
+ v, _ := cache.Get(string(targetItem.key))
+ require.Equal(b, targetValue, v.([]byte))
+
+ b.ResetTimer()
+ for i := 0; i < b.N; i++ {
+ _, _ = cache.Get(string(targetKey))
+ }
+ })
+ b.Run("go-map", func(b *testing.B) {
+ m := make(map[string][]byte, amount)
+ for _, item := range items {
+ m[string(item.key)] = item.value
+ }
+ v, _ := m[string(targetItem.key)]
+ require.Equal(b, targetValue, v)
+
+ b.ResetTimer()
+ for i := 0; i < b.N; i++ {
+ _, _ = m[string(targetKey)]
+ }
+ })
 }
 
 func BenchmarkRandomSet(b *testing.B) {

diff --git a/memiavl/go.mod b/memiavl/go.mod
@@ -5,6 +5,7 @@ go 1.20
 require (
  github.com/cosmos/iavl v0.19.5
  github.com/hashicorp/go-multierror v1.1.1
+ github.com/hashicorp/golang-lru v0.5.5-0.20210104140557-80c98217689d
  github.com/ledgerwatch/erigon-lib v0.0.0-20230210071639-db0e7ed11263
  github.com/stretchr/testify v1.8.1
  github.com/tendermint/tm-db v0.6.7

diff --git a/memiavl/go.sum b/memiavl/go.sum
@@ -77,6 +77,8 @@ github.com/hashicorp/errwrap v1.1.0 h1:OxrOeh75EUXMY8TBjag2fzXGZ40LB6IKw45YeGUDY
 github.com/hashicorp/errwrap v1.1.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
 github.com/hashicorp/go-multierror v1.1.1 h1:H5DkEtf6CXdFp0N0Em5UCwQpXMWke8IA0+lD48awMYo=
 github.com/hashicorp/go-multierror v1.1.1/go.mod h1:iw975J/qwKPdAO1clOe2L8331t/9/fmwbPZ6JB6eMoM=
+github.com/hashicorp/golang-lru v0.5.5-0.20210104140557-80c98217689d h1:dg1dEPuWpEqDnvIw251EVy4zlP8gWbsGj4BsUKCRpYs=
+github.com/hashicorp/golang-lru v0.5.5-0.20210104140557-80c98217689d/go.mod h1:iADmTwqILo4mZ8BN3D2Q6+9jd8WM5uGBxy+E8yxSoD4=
 github.com/hashicorp/hcl v1.0.0/go.mod h1:E5yfLk+7swimpb2L/Alb/PJmXilQ/rhwaUYs4T20WEQ=
 github.com/hpcloud/tail v1.0.0/go.mod h1:ab1qPbhIpdTxEkNHXyeSf5vhxWSCs/tWer42PpOxQnU=
 github.com/inconshreveable/mousetrap v1.0.0/go.mod h1:PxqpIevigyE2G7u3NXJIT2ANytuPF1OarO4DADm73n8=