Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds options class.output and class.source for html documents #1335

Merged
merged 7 commits into from
Dec 13, 2016

Conversation

ijlyttle
Copy link
Contributor

@ijlyttle ijlyttle commented Dec 11, 2016

Addresses #1333

This work is just beginning - I am opening the PR now so that @yihui and @AmeliaMN can pull me back towards the right path should I go the wrong way.

  • code
    • adapt render_markdown() in hooks-md.R
      • class.source
      • class.output
      • clean out extraneous comments in hooks.t.output
  • documentation
  • add a name to DESCRIPTION/Contributors

If you prefer to keep all the feedback until the whole PR is "done", I'll send a signal when I think I am there.

FWIW, here's a gist with the Rmd file I've been using to test things.

@yihui
Copy link
Owner

yihui commented Dec 13, 2016

@ijlyttle
Copy link
Contributor Author

Will do - should not be much longer - thanks!

@ijlyttle
Copy link
Contributor Author

Done, methinks (mehopes). Thanks for the navigation through the process, @yihui!

@yihui yihui merged commit 81ce0ae into yihui:master Dec 13, 2016
@yihui yihui added this to the v1.16 milestone Dec 13, 2016
yihui added a commit that referenced this pull request Dec 13, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants