Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1487 #1519

Merged
merged 3 commits into from
Feb 27, 2018
Merged

Fix #1487 #1519

merged 3 commits into from
Feb 27, 2018

Conversation

haozhu233
Copy link
Contributor

No description provided.

yihui
yihui approved these changes Feb 27, 2018
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself to DESCRIPTION, and also add an item in NEWS.md (under version 1.21). Thanks!

@yihui yihui added this to the v1.21 milestone Feb 27, 2018
@haozhu233
Copy link
Contributor Author

Added. Thanks! :)

yihui
yihui reviewed Feb 27, 2018
View reviewed changes
DESCRIPTION Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
yihui
yihui approved these changes Feb 27, 2018
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks!

@yihui yihui merged commit 0da648b into yihui:master Feb 27, 2018
@haozhu233 haozhu233 mentioned this pull request Mar 19, 2018
Closed
@yihui yihui mentioned this pull request May 22, 2018
Closed
yihui added a commit that referenced this pull request Sep 10, 2019
@yihui
revert 0da648b: valign means vertical alignment of the tabular enviro…
fdd4394 
…nment, instead of the floating position of the table environment

now I have added a separate argument to control the floating position for the table

related issues: #1487 #1519 #1547
@yihui yihui mentioned this pull request Sep 10, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
2 participants
@haozhu233 @yihui