Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace stringr::str_dup() with paste()/rep() #2186

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Replace stringr::str_dup() with paste()/rep() #2186

merged 2 commits into from
Oct 19, 2022

Conversation

rich-iannone
Copy link
Collaborator

This PR replaces two uses of stringr::str_dup() with a base R equivalent.

@rich-iannone rich-iannone marked this pull request as ready for review October 19, 2022 14:33
yihui
yihui approved these changes Oct 19, 2022
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yihui yihui merged commit 1ce8286 into master Oct 19, 2022
@yihui yihui deleted the str-dup-replace branch October 19, 2022 15:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rich-iannone @yihui