Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace several stringr fns with base equivalents #2205

Merged
merged 18 commits into from
Dec 22, 2022
Merged

Replace several stringr fns with base equivalents #2205

merged 18 commits into from
Dec 22, 2022

Conversation

rich-iannone
Copy link
Collaborator

@rich-iannone rich-iannone commented Dec 22, 2022 •
edited
Loading

This PR replaces several uses of stringr functions with base equivalents. This is being done to remove the dependency on the stringr package. The stringr functions to be replaced are str_locate(), str_locate_all(), str_match_all(), and str_extract_all().

Fixes: #1549

@rich-iannone rich-iannone marked this pull request as ready for review December 22, 2022 20:35
yihui
yihui approved these changes Dec 22, 2022
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll take it from here.

@yihui yihui merged commit cc3b92a into master Dec 22, 2022
@yihui yihui deleted the stringr-fn-replacement branch December 22, 2022 23:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make stringr / stringi a soft dependency
2 participants
@rich-iannone @yihui